bugfix to compute the residual with Neumann BC correctly + concentrated force
1 unresolved thread
1 unresolved thread
Closes #49 (closed)
Merge request reports
Activity
Filter activity
changed milestone to %v0.3 - Improvement
added Bug label
requested review from @pcarrara
added 1 commit
- f02d4c85 - fixed a missing definition in the elasticity tests which caused the elasticity tests to fail
2 comments for @jheinzmann :
- Use imperative mood for your commit names: https://initialcommit.com/blog/Git-Commit-Message-Imperative-Mood My own quick explanation why: The commit message should not be like a diary what you did, but rather describe what this commit changes when it is applied (view of commit and not view of author)
- If you fix a commit which breaks the pipeline, squash the fix directly into the previous one, dont add an extra commit to the MR. This makes reviewing easier. Note: although this is encouraged on branches you own, this is forbidden on devel, main and other branches where multiple people are working on (except you pass on the branch to somebody else explicitley).
For now: I just will merge and squash the 2 commits here directly, which will solve the 2 above comments automatically.
mentioned in commit 2357eecf
Please register or sign in to reply