Skip to content

Ldap improvements

Johannes Zumthurm requested to merge ldap_improvements into master

Created by: NotSpecial

First of all, the structure of ldap.py is now simplified. The class is dropped and replaced by a few module level functions which are easier to understand.

Next the functions themselves have been rearranged to be easier to test. Some premature optimization has been removed: The updating of all users now uses the same function as the one for one user only, since there were not really noticable performance differences. Again, this simplifies testing.

Speaking of testing: Using mock, all ldap functions are now tested. There still are some integration tests to verify everything actually works with the eth ldap.

Finally a few changes in bootstrap, cli and sessions to use the new functions.

After all I am quite happy with this version now. A few points are still up for improvement and I have added them to ldap.py, but over all the code is much simpler and better tested now, which is nice.

Merge request reports