Skip to content

Fix Faro routes acting as catch-all and /login and 404 never matching as a result (#371)

Yuto Takano requested to merge fix-faro-route-404 into master

Fixes #371 (closed).

This MR:

  • extends FaroRoute to cover /login and the 404 handler as well, fixing the core issue of #371 (closed)
  • adds a FaroRoute/no-op abstraction over all Routes. This will be beneficial in the eventual upgrade to RR7, since there we can just replace <FaroRoute path="/"> with <FaroRouter>.
  • inlines userRoutes (since I felt it was quite ugly).
  • fixes the backend not sending /login over to the frontend. Technically this endpoint is never linked to, but it didn't make sense to have a route defined in the frontend that's not accessible

Merge request reports