From d27af783e0a476196af1b8f3a72976dbd0f32997 Mon Sep 17 00:00:00 2001
From: Neil Kim Nielsen <37108154+neilkimn@users.noreply.github.com>
Date: Tue, 23 Feb 2021 17:16:19 +0100
Subject: [PATCH] Change in how Netron takes parameters (#284)
* remove obsolete netron params
* set default ip and port
* set host and port as fixed params
* consistency
* Add MoveMulPastMaxPool transformation to streamlining (#285)
* Add MoveMulPastMaxPool transform to streamlining
* Add second call to transformation within streamlining
* [Docker] set Netron version to >=4.7.9
Co-authored-by: Neil Kim Nielsen <37108154+neilnielsen@users.noreply.github.com>
Co-authored-by: Felix Jentzsch <45395194+fpjentzsch@users.noreply.github.com>
Co-authored-by: Yaman Umuroglu <yamanu@xilinx.com>
---
docker/Dockerfile.finn_dev | 2 +-
src/finn/util/visualization.py | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/docker/Dockerfile.finn_dev b/docker/Dockerfile.finn_dev
index 46b3ffb25..35bc316b6 100644
--- a/docker/Dockerfile.finn_dev
+++ b/docker/Dockerfile.finn_dev
@@ -54,7 +54,7 @@ RUN pip install sphinx==3.1.2
RUN pip install sphinx_rtd_theme==0.5.0
RUN pip install pytest-xdist==2.0.0
RUN pip install pytest-parallel==0.1.0
-RUN pip install netron
+RUN pip install netron>=4.7.9
RUN pip install -e git+https://github.com/fbcotter/dataset_loading.git@0.0.4#egg=dataset_loading
# switch user
diff --git a/src/finn/util/visualization.py b/src/finn/util/visualization.py
index 9f0e9e8d7..3eb7e55e3 100644
--- a/src/finn/util/visualization.py
+++ b/src/finn/util/visualization.py
@@ -34,7 +34,6 @@ from IPython.display import IFrame
def showSrc(what):
print("".join(inspect.getsourcelines(what)[0]))
-
def showInNetron(model_filename):
- netron.start(model_filename, port=8081, host="0.0.0.0")
- return IFrame(src="http://0.0.0.0:8081/", width="100%", height=400)
+ netron.start(model_filename, address=("0.0.0.0", 8081))
+ return IFrame(src="http://0.0.0.0:8081/", width="100%", height=400)
\ No newline at end of file
--
GitLab