From 360817a3afff6e3c0d77fffec1b946b53a71e160 Mon Sep 17 00:00:00 2001
From: Hendrik Borras <hendrikborras@web.de>
Date: Fri, 6 Aug 2021 15:10:52 +0100
Subject: [PATCH] Refactoring as suggested by @rpitonak.

---
 src/finn/util/visualization.py | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/finn/util/visualization.py b/src/finn/util/visualization.py
index c3cdfc1e1..397bebb64 100644
--- a/src/finn/util/visualization.py
+++ b/src/finn/util/visualization.py
@@ -53,12 +53,10 @@ def showInNetron(model_filename: str, localhost_url: str = None, port: int = Non
     :return: The IFrame displaying the ONNX model.
     :rtype: IPython.lib.display.IFrame
     """
-    if port is None:
-        try:
-            port = int(os.environ["NETRON_PORT"])
-        except KeyError:
-            port = 8081
-    if localhost_url is None:
-        localhost_url = os.getenv("LOCALHOST_URL", default="localhost")
+    try:
+        port = port or int(os.getenv("NETRON_PORT", default="8081"))
+    except ValueError:
+        port = 8081
+    localhost_url = localhost_url or os.getenv("LOCALHOST_URL", default="localhost")
     netron.start(model_filename, address=("0.0.0.0", port), browse=False)
     return IFrame(src=f"http://{localhost_url}:{port}/", width="100%", height=400)
-- 
GitLab