GitLab

Now in all 6 functions the meaning of filename parameters are:
    - `fileroot` = filename without folder and extensions,
    - `dirname`  = containing folder, defaults to `"."` as before.
The caller is responsible for constructing the fileroot (e.g. `"slice_..."`).
Also, removed unused `stepID`.

Re-indented code

The code would not be correct because Grid::getH() returns the (legacy)
uniform grid spacing h_gridpoint which is identical for all dimensions.
Testing for MeshMap::uniform() means uniform in the corresponding
dimension but it is possible that hx != hy != hz in the most general
case.  In this case Grid::getH() does not work.

WARNING: this restricts you from using -nan as an argument

Maybe I don't want HDF5 at all. Still, print a warning every time you
run an HDF5-related function. It would make sense to remove the
functions completely, such that the user must disable the function calls
as well.

...which means Cubism is not anymore a header-only library.
If lazy, just include ArgumentParser.cpp instead of compiling it
separately.

This reduced the compilation time of CubismUP3D by about 40%.

So there is this BlockProcessing.h that fortunately noone uses, which
expects a compile time NTHREADS for some reason. Added a note for
whomever gets burned with a compilation error.

Not sure about this, but now Cubism automatically defines
`CUBISM_ALIGNMENT` if it is not already defined.
That means that if the app intends to define the value,
it must define it before including _any_ Cubism header.

An alternative would be to put these ifdefs to Matrix3D.h (the only file
using the constant), but probably better to be strict.

C++ reserves all names starting with `_X` for some capital letter `X`.
Instead, use `CUBISM_` prefix.
Cubism still accepts all macros, but pops out a warning if used.

Instead of using _BLOCKSIZE*_ macros, use Block::sizeX/Y/Z.
Slice dumper currently is not implemented for non-cubical blocks.
pack/unpack functions get block size as a runtime argument, which
shouldn't really affect performance.

In tests, avoid _Capitalized, as that formatting is reserved by C++.

Removing _HDF5_DOUBLE_PRECISION_ from the library.

It was used only by the old coupling framework examples.
Now we require the user app to specify the Block class by itself.