Skip to content

GitLab

Open
Created by mikolajr@mikolajrMaintainer

DeviceSequenceMixin inherit from collections.UserDict

DeviceSequenceMixin is really just an ordered dict (*), w/ extra start/stop and .KEY lookup, so it seems best to just follow Python API there.

(*) Note: dicts are ordered by default since Py 3.7 (which we take anyway advantage of)

In consequence:

  • instead of get_devices() all iterators are avail .keys()/.values()/.items()
  • instead of get_device use __getitem__/get()
  • instead of add_device()/remove_device() use __setitem__/__delitem__/pop()

@menneh this would not be backward compatible and would break your experiments code (some minor re-factoring would be needed on hvl-ccb package update, once released). Would that be fine w/ you?

Edited by mikolajr