To receive notifications about scheduled maintenance, please subscribe to the mailing-list gitlab-operations@sympa.ethz.ch. You can subscribe to the mailing-list at https://sympa.ethz.ch

Commit 4adbefb1 authored by Jonas Fankhauser's avatar Jonas Fankhauser
Browse files

Bug fix: Sigma was incorrectly defined. Now it dependes on speed of sound only, not wavenumber

parent b17c44d6
Pipeline #97945 failed with stages
in 2 minutes and 8 seconds
......@@ -76,7 +76,7 @@ class BaseYosioka(BaseSphereFrequencyComposite):
# Dependencies
self._xlambda.is_computed_by(self.particle._rho_f, self.fluid._rho_f)
self._sigma.is_computed_by(self.particle._k_f, self.fluid._k_f)
self._sigma.is_computed_by(self.particle._c_f, self.fluid._c_f)
log.info(str(self))
log.debug(repr(self))
......@@ -329,12 +329,11 @@ class BaseYosioka(BaseSphereFrequencyComposite):
def _compute_sigma(self) -> float:
"""
Compute sigma (ratio of k's)
Compute sigma (ratio of speed of sound)
:rtype: float
"""
# TODO: Define in terms of wave speeds rather than wavenumbers
return self.k_s / self.k_f
return self.c_s / self.c_f
def _compute_xlambda(self) -> float:
"""
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment