Commit c18204cd authored by amitjans's avatar amitjans
Browse files

Merge branch 'feedback2' into 'main'

Ex03 feedback added

See merge request !1
parents 91027068 781faf2e
......@@ -8,6 +8,12 @@
#include <iomanip> // for std::setprecision
#include <limits> // for std::numeric_limits
/*
Pascal:
Yes, I think your assessment is correct.
However, note that the two definitions you quote are identical.
*/
/*
The bisection method gets the true value of epsilon as
......@@ -65,5 +71,3 @@ int main() {
<< "Double: " << epsilon_limits<double>() << '\n'
<< "Long double: " << epsilon_limits<long double>() << '\n';
}
# Pascal:
# Looks good to me. Just note that the project name (and variables...) should
# "make sense".
# One complaint: Your shared library generation doesn't work. It took me way
# too long to find out what the issue is. I challenge you to track down the
# issue too.
#
# Note that the data file is a build artefact which I should be able to
# generate. No need to add this to the repo.
# require minimum version of CMake
cmake_minimum_required(VERSION 3.21)
cmake_minimum_required(VERSION 3.21)
# set name of project
project(Square)
......@@ -15,6 +25,7 @@ else()
set(SQUARE_LIBRARY_TYPE STATIC)
endif()
# tell CMake that there is another CMakeLists.txt in this subdirectory
add_subdirectory(integrator)
......@@ -26,5 +37,3 @@ target_link_libraries(print_integrals integratorLib)
# specify install rules
install(TARGETS print_integrals DESTINATION bin)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment